Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7f0adb53 authored by Pavel Shilovsky's avatar Pavel Shilovsky Committed by Steve French
Browse files

CIFS: Make accessing is_valid_oplock/dump_detail ops struct field safe 



Signed-off-by: default avatarPavel Shilovsky <pshilovsky@samba.org>
Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
parent ea319d57

fs/cifs/connect.c

+4 −2
Original line number Diff line number Diff line
@@ -1058,12 +1058,14 @@ cifs_demultiplex_thread(void *p) 
		if (mid_entry != NULL) {

			if (!mid_entry->multiRsp || mid_entry->multiEnd)

				mid_entry->callback(mid_entry);

		} else if (!server->ops->is_oplock_break(buf, server)) {

		} else if (!server->ops->is_oplock_break ||

			   !server->ops->is_oplock_break(buf, server)) {

			cERROR(1, "No task to wake, unknown frame received! "

				   "NumMids %d", atomic_read(&midCount));

			cifs_dump_mem("Received Data is: ", buf,

				      HEADER_SIZE(server));

#ifdef CONFIG_CIFS_DEBUG2

			if (server->ops->dump_detail)

				server->ops->dump_detail(buf);

			cifs_dump_mids(server);

#endif /* CIFS_DEBUG2 */