Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7e15de3a authored by Sascha Hauer's avatar Sascha Hauer Committed by Marc Kleine-Budde
Browse files

can: mcp251x: read-modify-write eflag only when needed 



Use read-modify-write instead of a simple write to change the register
contents, to close existing the race window between the original manual
read and write.

Signed-off-by: default avatarSascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
Acked-by: default avatarWolfgang Grandegger <wg@grandegger.com>
parent f3a3ed31

drivers/net/can/mcp251x.c

+2 −1
Original line number Diff line number Diff line
@@ -785,7 +785,8 @@ static irqreturn_t mcp251x_can_ist(int irq, void *dev_id) 


		mcp251x_write_bits(spi, CANINTF, intf, 0x00);



		mcp251x_write_reg(spi, EFLG, 0x00);

		if (eflag)

			mcp251x_write_bits(spi, EFLG, eflag, 0x00);



		/* Update can state */

		if (eflag & EFLG_TXBO) {