Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7e026c8c authored by Dan Williams's avatar Dan Williams
Browse files

dm: add ->copy_from_iter() dax operation support 



Allow device-mapper to route copy_from_iter operations to the
per-target implementation. In order for the device stacking to work we
need a dax_dev and a pgoff relative to that device. This gives each
layer of the stack the information it needs to look up the operation
pointer for the next level.

This conceptually allows for an array of mixed device drivers with
varying copy_from_iter implementations.

Reviewed-by: default avatarToshi Kani <toshi.kani@hpe.com>
Reviewed-by: default avatarMike Snitzer <snitzer@redhat.com>
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent 0aed55af

drivers/dax/super.c

+13 −0
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ 
#include <linux/cdev.h>

#include <linux/hash.h>

#include <linux/slab.h>

#include <linux/uio.h>

#include <linux/dax.h>

#include <linux/fs.h>
@@ -172,6 +173,18 @@ long dax_direct_access(struct dax_device *dax_dev, pgoff_t pgoff, long nr_pages, 
}

EXPORT_SYMBOL_GPL(dax_direct_access);



size_t dax_copy_from_iter(struct dax_device *dax_dev, pgoff_t pgoff, void *addr,

		size_t bytes, struct iov_iter *i)

{

	if (!dax_alive(dax_dev))

		return 0;



	if (!dax_dev->ops->copy_from_iter)

		return copy_from_iter(addr, bytes, i);

	return dax_dev->ops->copy_from_iter(dax_dev, pgoff, addr, bytes, i);

}

EXPORT_SYMBOL_GPL(dax_copy_from_iter);



bool dax_alive(struct dax_device *dax_dev)

{

	lockdep_assert_held(&dax_srcu);

drivers/md/dm-linear.c

+15 −0
Original line number Diff line number Diff line
@@ -159,6 +159,20 @@ static long linear_dax_direct_access(struct dm_target *ti, pgoff_t pgoff, 
	return dax_direct_access(dax_dev, pgoff, nr_pages, kaddr, pfn);

}



static size_t linear_dax_copy_from_iter(struct dm_target *ti, pgoff_t pgoff,

		void *addr, size_t bytes, struct iov_iter *i)

{

	struct linear_c *lc = ti->private;

	struct block_device *bdev = lc->dev->bdev;

	struct dax_device *dax_dev = lc->dev->dax_dev;

	sector_t dev_sector, sector = pgoff * PAGE_SECTORS;



	dev_sector = linear_map_sector(ti, sector);

	if (bdev_dax_pgoff(bdev, dev_sector, ALIGN(bytes, PAGE_SIZE), &pgoff))

		return 0;

	return dax_copy_from_iter(dax_dev, pgoff, addr, bytes, i);

}



static struct target_type linear_target = {

	.name   = "linear",

	.version = {1, 3, 0},
@@ -171,6 +185,7 @@ static struct target_type linear_target = { 
	.prepare_ioctl = linear_prepare_ioctl,

	.iterate_devices = linear_iterate_devices,

	.direct_access = linear_dax_direct_access,

	.dax_copy_from_iter = linear_dax_copy_from_iter,

};



int __init dm_linear_init(void)

drivers/md/dm-stripe.c

+20 −0
Original line number Diff line number Diff line
@@ -332,6 +332,25 @@ static long stripe_dax_direct_access(struct dm_target *ti, pgoff_t pgoff, 
	return dax_direct_access(dax_dev, pgoff, nr_pages, kaddr, pfn);

}



static size_t stripe_dax_copy_from_iter(struct dm_target *ti, pgoff_t pgoff,

		void *addr, size_t bytes, struct iov_iter *i)

{

	sector_t dev_sector, sector = pgoff * PAGE_SECTORS;

	struct stripe_c *sc = ti->private;

	struct dax_device *dax_dev;

	struct block_device *bdev;

	uint32_t stripe;



	stripe_map_sector(sc, sector, &stripe, &dev_sector);

	dev_sector += sc->stripe[stripe].physical_start;

	dax_dev = sc->stripe[stripe].dev->dax_dev;

	bdev = sc->stripe[stripe].dev->bdev;



	if (bdev_dax_pgoff(bdev, dev_sector, ALIGN(bytes, PAGE_SIZE), &pgoff))

		return 0;

	return dax_copy_from_iter(dax_dev, pgoff, addr, bytes, i);

}



/*

 * Stripe status:

 *
@@ -451,6 +470,7 @@ static struct target_type stripe_target = { 
	.iterate_devices = stripe_iterate_devices,

	.io_hints = stripe_io_hints,

	.direct_access = stripe_dax_direct_access,

	.dax_copy_from_iter = stripe_dax_copy_from_iter,

};



int __init dm_stripe_init(void)

drivers/md/dm.c

+26 −0
Original line number Diff line number Diff line
@@ -19,6 +19,7 @@ 
#include <linux/dax.h>

#include <linux/slab.h>

#include <linux/idr.h>

#include <linux/uio.h>

#include <linux/hdreg.h>

#include <linux/delay.h>

#include <linux/wait.h>
@@ -969,6 +970,30 @@ static long dm_dax_direct_access(struct dax_device *dax_dev, pgoff_t pgoff, 
	return ret;

}



static size_t dm_dax_copy_from_iter(struct dax_device *dax_dev, pgoff_t pgoff,

		void *addr, size_t bytes, struct iov_iter *i)

{

	struct mapped_device *md = dax_get_private(dax_dev);

	sector_t sector = pgoff * PAGE_SECTORS;

	struct dm_target *ti;

	long ret = 0;

	int srcu_idx;



	ti = dm_dax_get_live_target(md, sector, &srcu_idx);



	if (!ti)

		goto out;

	if (!ti->type->dax_copy_from_iter) {

		ret = copy_from_iter(addr, bytes, i);

		goto out;

	}

	ret = ti->type->dax_copy_from_iter(ti, pgoff, addr, bytes, i);

 out:

	dm_put_live_table(md, srcu_idx);



	return ret;

}



/*

 * A target may call dm_accept_partial_bio only from the map routine.  It is

 * allowed for all bio types except REQ_PREFLUSH.
@@ -2859,6 +2884,7 @@ static const struct block_device_operations dm_blk_dops = { 


static const struct dax_operations dm_dax_ops = {

	.direct_access = dm_dax_direct_access,

	.copy_from_iter = dm_dax_copy_from_iter,

};



/*

include/linux/dax.h

+2 −0
Original line number Diff line number Diff line
@@ -78,6 +78,8 @@ void kill_dax(struct dax_device *dax_dev); 
void *dax_get_private(struct dax_device *dax_dev);

long dax_direct_access(struct dax_device *dax_dev, pgoff_t pgoff, long nr_pages,

		void **kaddr, pfn_t *pfn);

size_t dax_copy_from_iter(struct dax_device *dax_dev, pgoff_t pgoff, void *addr,

		size_t bytes, struct iov_iter *i);



/*

 * We use lowest available bit in exceptional entry for locking, one bit for