Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7de82186 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

drm/msm/gpu: Fix a couple memory leaks in debugfs 



[ Upstream commit 51270de91412b819f654b849db3bf92dac0a0855 ]

The msm_gpu_open() function should free "show_priv" on error or it
causes static checker warnings.

Fixes: 4f776f45 ("drm/msm/gpu: Convert the GPU show function to use the GPU state")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarRob Clark <robdclark@gmail.com>
Signed-off-by: default avatarSean Paul <seanpaul@chromium.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 35516413

drivers/gpu/drm/msm/msm_debugfs.c

+11 −4
Original line number Diff line number Diff line
@@ -84,7 +84,7 @@ static int msm_gpu_open(struct inode *inode, struct file *file) 


	ret = mutex_lock_interruptible(&dev->struct_mutex);

	if (ret)

		return ret;

		goto free_priv;



	pm_runtime_get_sync(&gpu->pdev->dev);

	show_priv->state = gpu->funcs->gpu_state_get(gpu);
@@ -94,13 +94,20 @@ static int msm_gpu_open(struct inode *inode, struct file *file) 


	if (IS_ERR(show_priv->state)) {

		ret = PTR_ERR(show_priv->state);

		kfree(show_priv);

		return ret;

		goto free_priv;

	}



	show_priv->dev = dev;



	return single_open(file, msm_gpu_show, show_priv);

	ret = single_open(file, msm_gpu_show, show_priv);

	if (ret)

		goto free_priv;



	return 0;



free_priv:

	kfree(show_priv);

	return ret;

}



static const struct file_operations msm_gpu_fops = {