Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7de2763d authored by Marek Vasut's avatar Marek Vasut Committed by Mark Brown
Browse files

ASoC: fsl_ssi: Remove .num_reg_defaults_raw from regmap_config 



This driver provides no .reg_defaults_raw in regmap_config, so
the .num_reg_defaults_raw is useless, and, in fact harmful. It
triggers kernel crash in regmap_init which tries to access the
register defaults.

Signed-off-by: default avatarMarek Vasut <marex@denx.de>
Acked-by: default avatarNicolin Chen <nicoleotsuka@gmail.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent bfcf928d

sound/soc/fsl/fsl_ssi.c

+0 −3
Original line number Diff line number Diff line
@@ -177,7 +177,6 @@ static const struct regmap_config fsl_ssi_regconfig = { 
	.val_bits = 32,

	.reg_stride = 4,

	.val_format_endian = REGMAP_ENDIAN_NATIVE,

	.num_reg_defaults_raw = CCSR_SSI_SACCDIS / sizeof(uint32_t) + 1,

	.readable_reg = fsl_ssi_readable_reg,

	.volatile_reg = fsl_ssi_volatile_reg,

	.precious_reg = fsl_ssi_precious_reg,
@@ -1501,8 +1500,6 @@ static int fsl_ssi_probe(struct platform_device *pdev) 
		 * don't have SACC{ST,EN,DIS} regs.

		 */

		regconfig.max_register = CCSR_SSI_SRMSK;

		regconfig.num_reg_defaults_raw =

			CCSR_SSI_SRMSK / sizeof(uint32_t) + 1;

	}



	ret = of_property_match_string(np, "clock-names", "ipg");