Commit 7d5e049e authored Aug 10, 2018 by Darrick J. Wong

iomap: fix WARN_ON_ONCE on uninitialized variable



In commit 9dc55f13 ("iomap: add support for sub-pagesize buffered
I/O without buffer heads") we moved the initialization of poff (it's
computed from pos) into a separate helper function.  Inline data only
ever deals with pos == 0, hence the WARN_ON_ONCE, but now we're testing
an uninitialized variable.

Therefore, change the test to check the parameter directly.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

parent 1fc25f51

fs/iomap.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -290,7 +290,7 @@ iomap_readpage_actor(struct inode inode, loff_t pos, loff_t length, void data,
		sector_t sector;

		if (iomap->type == IOMAP_INLINE) {
		WARN_ON_ONCE(poff);
		WARN_ON_ONCE(pos);
		iomap_read_inline_data(inode, page, iomap);
		return PAGE_SIZE;
		}