Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7c604079 authored by Dan Williams's avatar Dan Williams Committed by Greg Kroah-Hartman
Browse files

usb: don't clear FEAT_C_ENABLE on usb_port_runtime_resume failure 



Three reasons:
1/ It's an invalid operation on usb3 ports
2/ There's no guarantee of when / if a usb2 port has entered an error
   state relative to PORT_POWER request
3/ The port is active / powered at this point, so khubd will clear it as
   a matter of course

Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7ad3c470

drivers/usb/core/port.c

+0 −1
Original line number Diff line number Diff line
@@ -110,7 +110,6 @@ static int usb_port_runtime_resume(struct device *dev) 
		if (retval < 0)

			dev_dbg(&port_dev->dev, "can't get reconnection after setting port  power on, status %d\n",

					retval);

		usb_clear_port_feature(hdev, port1, USB_PORT_FEAT_C_ENABLE);

		retval = 0;

	}