Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7c0ace54 authored by Julia Lawall's avatar Julia Lawall Committed by Greg Kroah-Hartman
Browse files

Staging: vme: bridges: Add missing unlocks 

Add a spin_unlock and mutex_unlock missing on the error path.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression E1;
@@

* spin_lock(E1,...);
  <+... when != E1
  if (...) {
    ... when != E1
*   return ...;
  }
  ...+>
* spin_unlock(E1,...);
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarMartyn Welch <martyn.welch@ge.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 45f9f018

drivers/staging/vme/bridges/vme_ca91cx42.c

+3 −1
Original line number Diff line number Diff line
@@ -900,7 +900,8 @@ unsigned int ca91cx42_master_rmw(struct vme_master_resource *image, 
	/* Address must be 4-byte aligned */

	if (pci_addr & 0x3) {

		dev_err(dev, "RMW Address not 4-byte aligned\n");

		return -EINVAL;

		result = -EINVAL;

		goto out;

	}



	/* Ensure RMW Disabled whilst configuring */
@@ -921,6 +922,7 @@ unsigned int ca91cx42_master_rmw(struct vme_master_resource *image, 
	/* Disable RMW */

	iowrite32(0, bridge->base + SCYC_CTL);



out:

	spin_unlock(&(image->lock));



	mutex_unlock(&(bridge->vme_rmw));