Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7c011435 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

qlcnic: fix a return in qlcnic_dcb_get_capability() 



[ Upstream commit c94f026fb742b2d3199422751dbc4f6fc0e753d8 ]

These functions are supposed to return one on failure and zero on
success.  Returning a zero here could cause uninitialized variable
bugs in several of the callers.  For example:

    drivers/scsi/cxgbi/cxgb4i/cxgb4i.c:1660 get_iscsi_dcb_priority()
    error: uninitialized symbol 'caps'.

Fixes: 48365e48 ("qlcnic: dcb: Add support for CEE Netlink interface.")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 321c40dc

drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c

+1 −1
Original line number Diff line number Diff line
@@ -883,7 +883,7 @@ static u8 qlcnic_dcb_get_capability(struct net_device *netdev, int capid, 
	struct qlcnic_adapter *adapter = netdev_priv(netdev);



	if (!test_bit(QLCNIC_DCB_STATE, &adapter->dcb->state))

		return 0;

		return 1;



	switch (capid) {

	case DCB_CAP_ATTR_PG: