Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7b83c629 authored by Heiko Carstens's avatar Heiko Carstens Committed by Martin Schwidefsky
Browse files

s390/guarded storage: simplify task exit handling 



Free data structures required for guarded storage from
arch_release_task_struct(). This allows to simplify the code a bit,
and also makes the semantics a bit easier: arch_release_task_struct()
is never called from the task that is being removed.

In addition this allows to get rid of exit_thread() in a later patch.

Signed-off-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent 5ef2d523

arch/s390/include/asm/processor.h

+2 −2
Original line number Diff line number Diff line
@@ -220,8 +220,8 @@ void show_cacheinfo(struct seq_file *m); 
/* Free all resources held by a thread. */

static inline void release_thread(struct task_struct *tsk) { }



/* Free guarded storage control block for current */

void exit_thread_gs(void);

/* Free guarded storage control block */

void guarded_storage_release(struct task_struct *tsk);



unsigned long get_wchan(struct task_struct *p);

#define task_pt_regs(tsk) ((struct pt_regs *) \

arch/s390/kernel/guarded_storage.c

+3 −6
Original line number Diff line number Diff line
@@ -11,13 +11,10 @@ 
#include <asm/guarded_storage.h>

#include "entry.h"



void exit_thread_gs(void)

void guarded_storage_release(struct task_struct *tsk)

{

	preempt_disable();

	kfree(current->thread.gs_cb);

	kfree(current->thread.gs_bc_cb);

	current->thread.gs_cb = current->thread.gs_bc_cb = NULL;

	preempt_enable();

	kfree(tsk->thread.gs_cb);

	kfree(tsk->thread.gs_bc_cb);

}



static int gs_enable(void)

arch/s390/kernel/process.c

+1 −2
Original line number Diff line number Diff line
@@ -48,8 +48,6 @@ extern void kernel_thread_starter(void); 
 */

void exit_thread(struct task_struct *tsk)

{

	if (tsk == current)

		exit_thread_gs();

}



void flush_thread(void)
@@ -59,6 +57,7 @@ void flush_thread(void) 
void arch_release_task_struct(struct task_struct *tsk)

{

	runtime_instr_release(tsk);

	guarded_storage_release(tsk);

}



int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src)