Commit 7ad94699 authored Jul 02, 2018 by Finn Thain Committed by Michael Ellerman Jul 31, 2018

macintosh/via-pmu: Don't clear shift register interrupt flag twice



The shift register interrupt flag gets cleared in via_pmu_interrupt()
and once again in pmu_sr_intr(). Fix this theoretical race condition.

Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent 576d5290

drivers/macintosh/via-pmu.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1421,7 +1421,6 @@ pmu_sr_intr(void)

		if (in_8(&via[B]) & TREQ) {
		printk(KERN_ERR "PMU: spurious SR intr (%x)\n", in_8(&via[B]));
		out_8(&via[IFR], SR_INT);
		return NULL;
		}
		/* The ack may not yet be low when we get the interrupt */