Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7a28a154 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jeremy Kerr
Browse files

[POWERPC] spufs: don't requeue victim contex in find_victim if it's not in spu_run 



We should not requeue the victim context in find_victim if the owner is
not in spu_run. It's first not needed because leaving the context on
the spu is an optimization and second is harmful because it means the
owner could re-enter spu_run when the context is on the runqueue and
trip the BUG_ON in __spu_update_sched_info.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarJeremy Kerr <jk@ozlabs.org>
parent 826be063

arch/powerpc/platforms/cell/spufs/sched.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -659,6 +659,7 @@ static struct spu *find_victim(struct spu_context *ctx) 




			victim->stats.invol_ctx_switch++;

			victim->stats.invol_ctx_switch++;

			spu->stats.invol_ctx_switch++;

			spu->stats.invol_ctx_switch++;

			if (test_bit(SPU_SCHED_SPU_RUN, &ctx->sched_flags))

				spu_add_to_rq(victim);

				spu_add_to_rq(victim);





			mutex_unlock(&victim->state_mutex);

			mutex_unlock(&victim->state_mutex);