Commit 7a1e9d82 authored Jan 25, 2011 by Mike Snitzer Committed by James Bottomley Feb 12, 2011

[SCSI] scsi_dh_hp_sw: fix deadlock in start_stop_endio



The use of blk_execute_rq_nowait() implies __blk_put_request() is needed
in start_stop_endio() rather than blk_put_request() --
blk_finish_request() is called with queue lock already held.

Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>

parent 98cb7e44

drivers/scsi/device_handler/scsi_dh_hp_sw.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -225,7 +225,8 @@ static void start_stop_endio(struct request *req, int error)
		}
		}
		done:
		blk_put_request(req);
		req->end_io_data = NULL;
		__blk_put_request(req->q, req);
		if (h->callback_fn) {
		h->callback_fn(h->callback_data, err);
		h->callback_fn = h->callback_data = NULL;