Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 79cabaa3 authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab
Browse files

[media] cec: log reason for returning -EINVAL 



When validating the struct cec_s_log_addrs input a debug message is printed
for all except two of the 'return -EINVAL' paths.

Also log the reason for the missing two paths.

Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 25c21078

drivers/media/cec/cec-adap.c

+6 −2
Original line number Diff line number Diff line
@@ -1461,12 +1461,16 @@ int __cec_s_log_addrs(struct cec_adapter *adap, 
	 * within the correct range.

	 */

	if (log_addrs->vendor_id != CEC_VENDOR_ID_NONE &&

	    (log_addrs->vendor_id & 0xff000000) != 0)

	    (log_addrs->vendor_id & 0xff000000) != 0) {

		dprintk(1, "invalid vendor ID\n");

		return -EINVAL;

	}



	if (log_addrs->cec_version != CEC_OP_CEC_VERSION_1_4 &&

	    log_addrs->cec_version != CEC_OP_CEC_VERSION_2_0)

	    log_addrs->cec_version != CEC_OP_CEC_VERSION_2_0) {

		dprintk(1, "invalid CEC version\n");

		return -EINVAL;

	}



	if (log_addrs->num_log_addrs > 1)

		for (i = 0; i < log_addrs->num_log_addrs; i++)