Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7991cb9c authored by Michael Chan's avatar Michael Chan Committed by David S. Miller
Browse files

bnxt_en: Fix ethtool -x crash when device is down. 



Fix ethtool .get_rxfh() crash by checking for valid indirection table
address before copying the data.

Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 949989b3

drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

+8 −3
Original line number Diff line number Diff line
@@ -870,17 +870,22 @@ static int bnxt_get_rxfh(struct net_device *dev, u32 *indir, u8 *key, 
			 u8 *hfunc)

{

	struct bnxt *bp = netdev_priv(dev);

	struct bnxt_vnic_info *vnic = &bp->vnic_info[0];

	struct bnxt_vnic_info *vnic;

	int i = 0;



	if (hfunc)

		*hfunc = ETH_RSS_HASH_TOP;



	if (indir)

	if (!bp->vnic_info)

		return 0;



	vnic = &bp->vnic_info[0];

	if (indir && vnic->rss_table) {

		for (i = 0; i < HW_HASH_INDEX_SIZE; i++)

			indir[i] = le16_to_cpu(vnic->rss_table[i]);

	}



	if (key)

	if (key && vnic->rss_hash_key)

		memcpy(key, vnic->rss_hash_key, HW_HASH_KEY_SIZE);



	return 0;