Commit 797f91e6 authored May 28, 2017 by Hans de Goede Committed by Mauro Carvalho Chehab Jun 07, 2017

[media] staging: atomisp: Do not call dev_warn with a NULL device



Do not call dev_warn with a NULL device, this silence the following 2
warnings:

[   14.392194] (NULL device *): Failed to find gmin variable gmin_V2P8GPIO
[   14.392257] (NULL device *): Failed to find gmin variable gmin_V1P8GPIO

We could switch to using pr_warn for dev == NULL instead, but as comments
in the source indicate, the check for these 2 special gmin variables with
a NULL device is a workaround for 2 specific evaluation boards, so
completely silencing the missing warning for these actually is a good
thing.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

parent 008d8e10

drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -704,7 +704,7 @@ int gmin_get_config_var(struct device dev, const char var, char *out,
		if (ret == 0) {
		memcpy(out, ev->var.Data, ev->var.DataSize);
		*out_len = ev->var.DataSize;
		} else {
		} else if (dev) {
		dev_warn(dev, "Failed to find gmin variable %s\n", var8);
		}