Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 797074e4 authored by Akinobu Mita's avatar Akinobu Mita Committed by Linus Torvalds
Browse files

fs: use list_for_each_entry_reverse and kill sb_entry 



Use list_for_each_entry_reverse for super_blocks list and remove
unused sb_entry macro.

Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent e8462caa

fs/fs-writeback.c

+2 −5
Original line number Original line Diff line number Diff line
@@ -515,8 +515,7 @@ writeback_inodes(struct writeback_control *wbc) 
	might_sleep();

	might_sleep();

	spin_lock(&sb_lock);

	spin_lock(&sb_lock);

restart:

restart:

	sb = sb_entry(super_blocks.prev);

	list_for_each_entry_reverse(sb, &super_blocks, s_list) {

	for (; sb != sb_entry(&super_blocks); sb = sb_entry(sb->s_list.prev)) {

		if (sb_has_dirty_inodes(sb)) {

		if (sb_has_dirty_inodes(sb)) {

			/* we're making our own get_super here */

			/* we're making our own get_super here */

			sb->s_count++;

			sb->s_count++;
@@ -581,10 +580,8 @@ static void set_sb_syncing(int val) 
{

{

	struct super_block *sb;

	struct super_block *sb;

	spin_lock(&sb_lock);

	spin_lock(&sb_lock);

	sb = sb_entry(super_blocks.prev);

	list_for_each_entry_reverse(sb, &super_blocks, s_list)

	for (; sb != sb_entry(&super_blocks); sb = sb_entry(sb->s_list.prev)) {

		sb->s_syncing = val;

		sb->s_syncing = val;

	}

	spin_unlock(&sb_lock);

	spin_unlock(&sb_lock);

}

}

include/linux/fs.h

+0 −1
Original line number Original line Diff line number Diff line
@@ -977,7 +977,6 @@ extern int send_sigurg(struct fown_struct *fown); 
extern struct list_head super_blocks;

extern struct list_head super_blocks;

extern spinlock_t sb_lock;

extern spinlock_t sb_lock;





#define sb_entry(list)	list_entry((list), struct super_block, s_list)

#define S_BIAS (1<<30)

#define S_BIAS (1<<30)

struct super_block {

struct super_block {

	struct list_head	s_list;		/* Keep this first */

	struct list_head	s_list;		/* Keep this first */