Commit 7851496a authored Apr 21, 2016 by Sinclair Yeh

drm/vmwgfx: Fix order of operation



mode->hdisplay * (var->bits_per_pixel + 7) gets evaluated before
the division, potentially making the pitch larger than it should
be.

Since the original intention is to do a div-round-up, just use
the macro instead.

Signed-off-by: Sinclair Yeh <syeh@vmware.com>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>

parent e02e5884

drivers/gpu/drm/vmwgfx/vmwgfx_fb.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -574,7 +574,7 @@ static int vmw_fb_set_par(struct fb_info *info)
		old_mode = NULL;
		} else if (!vmw_kms_validate_mode_vram(vmw_priv,
		mode->hdisplay *
		(var->bits_per_pixel + 7) / 8,
		DIV_ROUND_UP(var->bits_per_pixel, 8),
		mode->vdisplay)) {
		drm_mode_destroy(vmw_priv->dev, mode);
		return -EINVAL;