Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7792fe4f authored by Shannon Nelson's avatar Shannon Nelson Committed by Jeff Kirsher
Browse files

i40e: simplify error messages for dump descriptor 



debugfs fixes: We don't really need to give usage messages for data errors,
only for invalid command errors.

Change-Id: If3f74ac49e43c3ced7fd388323fa738ac145e055
Signed-off-by: default avatarShannon Nelson <shannon.nelson@intel.com>
Signed-off-by: default avatarJesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 29d0790e

drivers/net/ethernet/intel/i40e/i40e_debugfs.c

+2 −14
Original line number Diff line number Diff line
@@ -766,20 +766,11 @@ static void i40e_dbg_dump_desc(int cnt, int vsi_seid, int ring_id, int desc_n, 


	vsi = i40e_dbg_find_vsi(pf, vsi_seid);

	if (!vsi) {

		dev_info(&pf->pdev->dev,

			 "vsi %d not found\n", vsi_seid);

		if (is_rx_ring)

			dev_info(&pf->pdev->dev, "dump desc rx <vsi_seid> <ring_id> [<desc_n>]\n");

		else

			dev_info(&pf->pdev->dev, "dump desc tx <vsi_seid> <ring_id> [<desc_n>]\n");

		dev_info(&pf->pdev->dev, "vsi %d not found\n", vsi_seid);

		return;

	}

	if (ring_id >= vsi->num_queue_pairs || ring_id < 0) {

		dev_info(&pf->pdev->dev, "ring %d not found\n", ring_id);

		if (is_rx_ring)

			dev_info(&pf->pdev->dev, "dump desc rx <vsi_seid> <ring_id> [<desc_n>]\n");

		else

			dev_info(&pf->pdev->dev, "dump desc tx <vsi_seid> <ring_id> [<desc_n>]\n");

		return;

	}

	if (!vsi->tx_rings) {
@@ -836,10 +827,7 @@ static void i40e_dbg_dump_desc(int cnt, int vsi_seid, int ring_id, int desc_n, 
				 desc_n, ds->read.pkt_addr, ds->read.hdr_addr,

				 ds->read.rsvd1, ds->read.rsvd2);

	} else {

		if (is_rx_ring)

			dev_info(&pf->pdev->dev, "dump desc rx <vsi_seid> <ring_id> [<desc_n>]\n");

		else

			dev_info(&pf->pdev->dev, "dump desc tx <vsi_seid> <ring_id> [<desc_n>]\n");

		dev_info(&pf->pdev->dev, "dump desc rx/tx <vsi_seid> <ring_id> [<desc_n>]\n");

	}

}