Commit 778e1171 authored Dec 21, 2020 by Dinghao Liu Committed by Greg Kroah-Hartman Jan 17, 2021

net/mlx5e: Fix memleak in mlx5e_create_l2_table_groups



commit 5b0bb12c58ac7d22e05b5bfdaa30a116c8c32e32 upstream.

When mlx5_create_flow_group() fails, ft->g should be
freed just like when kvzalloc() fails. The caller of
mlx5e_create_l2_table_groups() does not catch this
issue on failure, which leads to memleak.

Fixes: 33cfaaa8 ("net/mlx5e: Split the main flow steering table")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent e256a7cd

drivers/net/ethernet/mellanox/mlx5/core/en_fs.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1312,6 +1312,7 @@ static int mlx5e_create_l2_table_groups(struct mlx5e_l2_table *l2_table)
		ft->g[ft->num_groups] = NULL;
		mlx5e_destroy_groups(ft);
		kvfree(in);
		kfree(ft->g);

		return err;
		}