Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7736b6ed authored by Jakub Kicinski's avatar Jakub Kicinski Committed by Daniel Borkmann
Browse files

selftests/bpf: add test for sharing objects between netdevs 



Add tests for sharing programs and maps between different netdevs.
Use netdevsim's ability to pretend multiple netdevs belong to the
same "ASIC".

Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: default avatarQuentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
parent b5faa20d

tools/testing/selftests/bpf/test_offload.py

+142 −4
Original line number Diff line number Diff line
@@ -158,8 +158,9 @@ def tool(name, args, flags, JSON=True, ns="", fail=True, include_stderr=False): 
    else:

        return ret, out



def bpftool(args, JSON=True, ns="", fail=True):

    return tool("bpftool", args, {"json":"-p"}, JSON=JSON, ns=ns, fail=fail)

def bpftool(args, JSON=True, ns="", fail=True, include_stderr=False):

    return tool("bpftool", args, {"json":"-p"}, JSON=JSON, ns=ns,

                fail=fail, include_stderr=include_stderr)



def bpftool_prog_list(expected=None, ns=""):

    _, progs = bpftool("prog show", JSON=True, ns=ns, fail=True)
@@ -201,6 +202,21 @@ def bpftool_map_list_wait(expected=0, n_retry=20): 
        time.sleep(0.05)

    raise Exception("Time out waiting for map counts to stabilize want %d, have %d" % (expected, nmaps))



def bpftool_prog_load(sample, file_name, maps=[], prog_type="xdp", dev=None,

                      fail=True, include_stderr=False):

    args = "prog load %s %s" % (os.path.join(bpf_test_dir, sample), file_name)

    if prog_type is not None:

        args += " type " + prog_type

    if dev is not None:

        args += " dev " + dev

    if len(maps):

        args += " map " + " map ".join(maps)



    res = bpftool(args, fail=fail, include_stderr=include_stderr)

    if res[0] == 0:

        files.append(file_name)

    return res



def ip(args, force=False, JSON=True, ns="", fail=True, include_stderr=False):

    if force:

        args = "-force " + args
@@ -307,7 +323,9 @@ class NetdevSim: 
    Class for netdevsim netdevice and its attributes.

    """



    def __init__(self):

    def __init__(self, link=None):

        self.link = link



        self.dev = self._netdevsim_create()

        devs.append(self)
@@ -321,8 +339,9 @@ class NetdevSim: 
        return self.dev[key]



    def _netdevsim_create(self):

        link = "" if self.link is None else "link " + self.link.dev['ifname']

        _, old  = ip("link show")

        ip("link add sim%d type netdevsim")

        ip("link add sim%d {link} type netdevsim".format(link=link))

        _, new  = ip("link show")



        for dev in new:
@@ -848,6 +867,25 @@ try: 
    sim.set_mtu(1500)



    sim.wait_for_flush()

    start_test("Test non-offload XDP attaching to HW...")

    bpftool_prog_load("sample_ret0.o", "/sys/fs/bpf/nooffload")

    nooffload = bpf_pinned("/sys/fs/bpf/nooffload")

    ret, _, err = sim.set_xdp(nooffload, "offload",

                              fail=False, include_stderr=True)

    fail(ret == 0, "attached non-offloaded XDP program to HW")

    check_extack_nsim(err, "xdpoffload of non-bound program.", args)

    rm("/sys/fs/bpf/nooffload")



    start_test("Test offload XDP attaching to drv...")

    bpftool_prog_load("sample_ret0.o", "/sys/fs/bpf/offload",

                      dev=sim['ifname'])

    offload = bpf_pinned("/sys/fs/bpf/offload")

    ret, _, err = sim.set_xdp(offload, "drv", fail=False, include_stderr=True)

    fail(ret == 0, "attached offloaded XDP program to drv")

    check_extack(err, "using device-bound program without HW_MODE flag is not supported.", args)

    rm("/sys/fs/bpf/offload")

    sim.wait_for_flush()



    start_test("Test XDP offload...")

    _, _, err = sim.set_xdp(obj, "offload", verbose=True, include_stderr=True)

    ipl = sim.ip_link_show(xdp=True)
@@ -1141,6 +1179,106 @@ try: 
    fail(ret == 0,

         "netdevsim didn't refuse to create a map with offload disabled")



    sim.remove()



    start_test("Test multi-dev ASIC program reuse...")

    simA = NetdevSim()

    simB1 = NetdevSim()

    simB2 = NetdevSim(link=simB1)

    simB3 = NetdevSim(link=simB1)

    sims = (simA, simB1, simB2, simB3)

    simB = (simB1, simB2, simB3)



    bpftool_prog_load("sample_map_ret0.o", "/sys/fs/bpf/nsimA",

                      dev=simA['ifname'])

    progA = bpf_pinned("/sys/fs/bpf/nsimA")

    bpftool_prog_load("sample_map_ret0.o", "/sys/fs/bpf/nsimB",

                      dev=simB1['ifname'])

    progB = bpf_pinned("/sys/fs/bpf/nsimB")



    simA.set_xdp(progA, "offload", JSON=False)

    for d in simB:

        d.set_xdp(progB, "offload", JSON=False)



    start_test("Test multi-dev ASIC cross-dev replace...")

    ret, _ = simA.set_xdp(progB, "offload", force=True, JSON=False, fail=False)

    fail(ret == 0, "cross-ASIC program allowed")

    for d in simB:

        ret, _ = d.set_xdp(progA, "offload", force=True, JSON=False, fail=False)

        fail(ret == 0, "cross-ASIC program allowed")



    start_test("Test multi-dev ASIC cross-dev install...")

    for d in sims:

        d.unset_xdp("offload")



    ret, _, err = simA.set_xdp(progB, "offload", force=True, JSON=False,

                               fail=False, include_stderr=True)

    fail(ret == 0, "cross-ASIC program allowed")

    check_extack_nsim(err, "program bound to different dev.", args)

    for d in simB:

        ret, _, err = d.set_xdp(progA, "offload", force=True, JSON=False,

                                fail=False, include_stderr=True)

        fail(ret == 0, "cross-ASIC program allowed")

        check_extack_nsim(err, "program bound to different dev.", args)



    start_test("Test multi-dev ASIC cross-dev map reuse...")



    mapA = bpftool("prog show %s" % (progA))[1]["map_ids"][0]

    mapB = bpftool("prog show %s" % (progB))[1]["map_ids"][0]



    ret, _ = bpftool_prog_load("sample_map_ret0.o", "/sys/fs/bpf/nsimB_",

                               dev=simB3['ifname'],

                               maps=["idx 0 id %d" % (mapB)],

                               fail=False)

    fail(ret != 0, "couldn't reuse a map on the same ASIC")

    rm("/sys/fs/bpf/nsimB_")



    ret, _, err = bpftool_prog_load("sample_map_ret0.o", "/sys/fs/bpf/nsimA_",

                                    dev=simA['ifname'],

                                    maps=["idx 0 id %d" % (mapB)],

                                    fail=False, include_stderr=True)

    fail(ret == 0, "could reuse a map on a different ASIC")

    fail(err.count("offload device mismatch between prog and map") == 0,

         "error message missing for cross-ASIC map")



    ret, _, err = bpftool_prog_load("sample_map_ret0.o", "/sys/fs/bpf/nsimB_",

                                    dev=simB1['ifname'],

                                    maps=["idx 0 id %d" % (mapA)],

                                    fail=False, include_stderr=True)

    fail(ret == 0, "could reuse a map on a different ASIC")

    fail(err.count("offload device mismatch between prog and map") == 0,

         "error message missing for cross-ASIC map")



    start_test("Test multi-dev ASIC cross-dev destruction...")

    bpftool_prog_list_wait(expected=2)



    simA.remove()

    bpftool_prog_list_wait(expected=1)



    ifnameB = bpftool("prog show %s" % (progB))[1]["dev"]["ifname"]

    fail(ifnameB != simB1['ifname'], "program not bound to originial device")

    simB1.remove()

    bpftool_prog_list_wait(expected=1)



    start_test("Test multi-dev ASIC cross-dev destruction - move...")

    ifnameB = bpftool("prog show %s" % (progB))[1]["dev"]["ifname"]

    fail(ifnameB not in (simB2['ifname'], simB3['ifname']),

         "program not bound to remaining devices")



    simB2.remove()

    ifnameB = bpftool("prog show %s" % (progB))[1]["dev"]["ifname"]

    fail(ifnameB != simB3['ifname'], "program not bound to remaining device")



    simB3.remove()

    bpftool_prog_list_wait(expected=0)



    start_test("Test multi-dev ASIC cross-dev destruction - orphaned...")

    ret, out = bpftool("prog show %s" % (progB), fail=False)

    fail(ret == 0, "got information about orphaned program")

    fail("error" not in out, "no error reported for get info on orphaned")

    fail(out["error"] != "can't get prog info: No such device",

         "wrong error for get info on orphaned")



    print("%s: OK" % (os.path.basename(__file__)))



finally: