Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 76ff0e64 authored by Pavan Savoy's avatar Pavan Savoy Committed by Greg Kroah-Hartman
Browse files

drivers:misc: ti-st: free skb on firmware download 



If during validation of the firmware download the data doesn't match what is
expected out of the chip, this calls for a firmware download failure and a
retry.
Free the SKB which collects response during such scenarios.

Signed-off-by: default avatarPavan Savoy <pavan_savoy@ti.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent d0344ef6

drivers/misc/ti-st/st_kim.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -68,6 +68,7 @@ void validate_firmware_response(struct kim_data_s *kim_gdata) 
	if (unlikely(skb->data[5] != 0)) {

	if (unlikely(skb->data[5] != 0)) {

		pr_err("no proper response during fw download");

		pr_err("no proper response during fw download");

		pr_err("data6 %x", skb->data[5]);

		pr_err("data6 %x", skb->data[5]);

		kfree_skb(skb);

		return;		/* keep waiting for the proper response */

		return;		/* keep waiting for the proper response */

	}

	}

	/* becos of all the script being downloaded */

	/* becos of all the script being downloaded */