Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 76ce37f0 authored by Markus Elfring's avatar Markus Elfring Committed by Linus Walleij
Browse files

pinctrl: Adjust five checks for null pointers 



MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The script “checkpatch.pl” pointed information out like the following.

Comparison to NULL could be written !…

Thus fix the affected source code places.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent de2eae26

drivers/pinctrl/pinconf.c

+5 −5
Original line number Diff line number Diff line
@@ -319,7 +319,7 @@ static int pinconf_pins_show(struct seq_file *s, void *what) 
		pin = pctldev->desc->pins[i].number;

		desc = pin_desc_get(pctldev, pin);

		/* Skip if we cannot search the pin */

		if (desc == NULL)

		if (!desc)

			continue;



		seq_printf(s, "pin %d (%s): ", pin, desc->name);
@@ -524,7 +524,7 @@ static ssize_t pinconf_dbg_config_write(struct file *file, 


	/* get arg 'device_name' */

	token = strsep(&b, " ");

	if (token == NULL)

	if (!token)

		return -EINVAL;

	if (strlen(token) >= MAX_NAME_LEN)

		return -EINVAL;
@@ -532,7 +532,7 @@ static ssize_t pinconf_dbg_config_write(struct file *file, 


	/* get arg 'state_name' */

	token = strsep(&b, " ");

	if (token == NULL)

	if (!token)

		return -EINVAL;

	if (strlen(token) >= MAX_NAME_LEN)

		return -EINVAL;
@@ -540,7 +540,7 @@ static ssize_t pinconf_dbg_config_write(struct file *file, 


	/* get arg 'pin_name' */

	token = strsep(&b, " ");

	if (token == NULL)

	if (!token)

		return -EINVAL;

	if (strlen(token) >= MAX_NAME_LEN)

		return -EINVAL;
@@ -548,7 +548,7 @@ static ssize_t pinconf_dbg_config_write(struct file *file, 


	/* get new_value of config' */

	token = strsep(&b, " ");

	if (token == NULL)

	if (!token)

		return -EINVAL;

	if (strlen(token) >= MAX_NAME_LEN)

		return -EINVAL;