Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 76ac8940 authored by Hannes Eder's avatar Hannes Eder Committed by Patrick McHardy
Browse files

netfilter: nf_nat_helper: tidy up adjust_tcp_sequence 



The variable 'other_way' gets initialized but is not read afterwards,
so remove it.  Pass the right arguments to a pr_debug call.

While being at tidy up a bit and it fix this checkpatch warning:
  WARNING: suspect code indent for conditional statements

Signed-off-by: default avatarHannes Eder <heder@google.com>
Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
parent 5ae27aa2

net/ipv4/netfilter/nf_nat_helper.c

+9 −13
Original line number Diff line number Diff line
@@ -41,18 +41,14 @@ adjust_tcp_sequence(u32 seq, 
		    struct nf_conn *ct,

		    enum ip_conntrack_info ctinfo)

{

	int dir;

	struct nf_nat_seq *this_way, *other_way;

	enum ip_conntrack_dir dir = CTINFO2DIR(ctinfo);

	struct nf_conn_nat *nat = nfct_nat(ct);

	struct nf_nat_seq *this_way = &nat->seq[dir];



	pr_debug("adjust_tcp_sequence: seq = %u, sizediff = %d\n", seq, seq);



	dir = CTINFO2DIR(ctinfo);



	this_way = &nat->seq[dir];

	other_way = &nat->seq[!dir];

	pr_debug("adjust_tcp_sequence: seq = %u, sizediff = %d\n",

		 seq, sizediff);



	pr_debug("nf_nat_resize_packet: Seq_offset before: ");

	pr_debug("adjust_tcp_sequence: Seq_offset before: ");

	DUMP_OFFSET(this_way);



	spin_lock_bh(&nf_nat_seqofs_lock);
@@ -69,7 +65,7 @@ adjust_tcp_sequence(u32 seq, 
	}

	spin_unlock_bh(&nf_nat_seqofs_lock);



	pr_debug("nf_nat_resize_packet: Seq_offset after: ");

	pr_debug("adjust_tcp_sequence: Seq_offset after: ");

	DUMP_OFFSET(this_way);

}