Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 762873c2 authored by OGAWA Hirofumi's avatar OGAWA Hirofumi Committed by Linus Torvalds
Browse files

vfs: fix unconditional write_super() call in file_fsync() 



We need to check ->s_dirt before calling write_super().  It became the cause
of an unneeded write.

This bug was noticed by Sudhanshu Saxena.

Signed-off-by: default avatarOGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 8f0cfa52

fs/sync.c

+1 −1
Original line number Diff line number Diff line
@@ -64,7 +64,7 @@ int file_fsync(struct file *filp, struct dentry *dentry, int datasync) 
	/* sync the superblock to buffers */

	sb = inode->i_sb;

	lock_super(sb);

	if (sb->s_op->write_super)

	if (sb->s_dirt && sb->s_op->write_super)

		sb->s_op->write_super(sb);

	unlock_super(sb);