Commit 75fdfc84 authored Mar 25, 2015 by Steve French

Fix warning on uninitialized buftype



Pointed out by coverity analyzer.  resp_buftype is
not initialized in one path which can rarely log
a spurious warning (buf is null so there will
not be a problem with freeing data, but if buf_type
were randomly set to wrong value could log a warning)

Reported by Coverity (CID 1269144)

Signed-off-by: Steve French <smfrench@gmail.com>
Acked-by: Shirish Pargaonkar <shirishpargaonkar@gmail.com>
Acked-by: Sachin Prabhu <sprabhu@redhat.com>
Reviewed-by: Jeff Layton <jlayton@poochiereds.net>

parent 2bd50fb3

fs/cifs/smb2pdu.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -2114,7 +2114,7 @@ SMB2_query_directory(const unsigned int xid, struct cifs_tcon *tcon,
	struct kvec iov[2];		struct kvec iov[2];
	int rc = 0;		int rc = 0;
	int len;		int len;
	int resp_buftype;		int resp_buftype = CIFS_NO_BUFFER;
	unsigned char *bufptr;		unsigned char *bufptr;
	struct TCP_Server_Info *server;		struct TCP_Server_Info *server;
	struct cifs_ses *ses = tcon->ses;		struct cifs_ses *ses = tcon->ses;