Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7575f825 authored by Arvind Yadav's avatar Arvind Yadav Committed by Rafael J. Wysocki
Browse files

cpufreq: kirkwood-cpufreq:- Handle return value of clk_prepare_enable() 



clk_prepare_enable() can fail here and we must check its return value.

Signed-off-by: default avatarArvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 6c770036

drivers/cpufreq/kirkwood-cpufreq.c

+16 −3
Original line number Diff line number Diff line
@@ -127,7 +127,12 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev) 
		return PTR_ERR(priv.cpu_clk);

	}



	clk_prepare_enable(priv.cpu_clk);

	err = clk_prepare_enable(priv.cpu_clk);

	if (err) {

		dev_err(priv.dev, "Unable to prepare cpuclk\n");

		return err;

	}



	kirkwood_freq_table[0].frequency = clk_get_rate(priv.cpu_clk) / 1000;



	priv.ddr_clk = of_clk_get_by_name(np, "ddrclk");
@@ -137,7 +142,11 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev) 
		goto out_cpu;

	}



	clk_prepare_enable(priv.ddr_clk);

	err = clk_prepare_enable(priv.ddr_clk);

	if (err) {

		dev_err(priv.dev, "Unable to prepare ddrclk\n");

		goto out_cpu;

	}

	kirkwood_freq_table[1].frequency = clk_get_rate(priv.ddr_clk) / 1000;



	priv.powersave_clk = of_clk_get_by_name(np, "powersave");
@@ -146,7 +155,11 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev) 
		err = PTR_ERR(priv.powersave_clk);

		goto out_ddr;

	}

	clk_prepare_enable(priv.powersave_clk);

	err = clk_prepare_enable(priv.powersave_clk);

	if (err) {

		dev_err(priv.dev, "Unable to prepare powersave clk\n");

		goto out_ddr;

	}



	of_node_put(np);

	np = NULL;