Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 74cbd96b authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge tag 'md/4.13-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/shli/md 

Pull MD fixes from Shaohua Li:

 - raid5-ppl fix by Artur. This one is introduced in this release cycle.

 - raid5 reshape fix by Xiao. This is an old bug and will be added to
   stable.

 - bitmap fix by Guoqing.

* tag 'md/4.13-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/shli/md:
  raid5-ppl: use BIOSET_NEED_BVECS when creating bioset
  Raid5 should update rdev->sectors after reshape
  md/bitmap: don't read page from device with Bitmap_sync
parents bef85bd7 6409e84e

drivers/md/bitmap.c

+2 −1
Original line number Diff line number Diff line
@@ -156,7 +156,8 @@ static int read_sb_page(struct mddev *mddev, loff_t offset, 


	rdev_for_each(rdev, mddev) {

		if (! test_bit(In_sync, &rdev->flags)

		    || test_bit(Faulty, &rdev->flags))

		    || test_bit(Faulty, &rdev->flags)

		    || test_bit(Bitmap_sync, &rdev->flags))

			continue;



		target = offset + index * (PAGE_SIZE/512);

drivers/md/md.h

+3 −1
Original line number Diff line number Diff line
@@ -134,7 +134,9 @@ enum flag_bits { 
	Faulty,			/* device is known to have a fault */

	In_sync,		/* device is in_sync with rest of array */

	Bitmap_sync,		/* ..actually, not quite In_sync.  Need a

				 * bitmap-based recovery to get fully in sync

				 * bitmap-based recovery to get fully in sync.

				 * The bit is only meaningful before device

				 * has been passed to pers->hot_add_disk.

				 */

	WriteMostly,		/* Avoid reading if at all possible */

	AutoDetected,		/* added by auto-detect */

drivers/md/raid5-ppl.c

+1 −1
Original line number Diff line number Diff line
@@ -1150,7 +1150,7 @@ int ppl_init_log(struct r5conf *conf) 
		goto err;

	}



	ppl_conf->bs = bioset_create(conf->raid_disks, 0, 0);

	ppl_conf->bs = bioset_create(conf->raid_disks, 0, BIOSET_NEED_BVECS);

	if (!ppl_conf->bs) {

		ret = -ENOMEM;

		goto err;

drivers/md/raid5.c

+1 −3
Original line number Diff line number Diff line
@@ -7951,12 +7951,10 @@ static void end_reshape(struct r5conf *conf) 
{



	if (!test_bit(MD_RECOVERY_INTR, &conf->mddev->recovery)) {

		struct md_rdev *rdev;



		spin_lock_irq(&conf->device_lock);

		conf->previous_raid_disks = conf->raid_disks;

		rdev_for_each(rdev, conf->mddev)

			rdev->data_offset = rdev->new_data_offset;

		md_finish_reshape(conf->mddev);

		smp_wmb();

		conf->reshape_progress = MaxSector;

		conf->mddev->reshape_position = MaxSector;