Commit 7473727b authored Jul 12, 2009 by Rakib Mullick Committed by Ingo Molnar Jul 13, 2009

x86, apic: Fix false positive section mismatch in numaq_32.c



The variable apic_numaq placed in noninit section references the
function wakeup_secondary_cpu_via_nmi(), which is in __cpuinit
section. Thus causes a section mismatch warning. To avoid such
mismatch we mark apic_numaq as __refdata.

We were warned by the following warning:

  WARNING: arch/x86/kernel/built-in.o(.data+0x932c): Section mismatch in
  reference from the variable apic_numaq to the function
  .cpuinit.text:wakeup_secondary_cpu_via_nmi()

Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
LKML-Reference: <b9df5fa10907120407p6b4f67dtf4d563155488188a@mail.gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 151586d0

arch/x86/kernel/apic/numaq_32.c

+2 −1

Original line number	Original line	Diff line number	Diff line
	@@ -493,7 +493,8 @@ static void numaq_setup_portio_remap(void)
	(u_long) xquad_portio, (u_long) num_quads*XQUAD_PORTIO_QUAD);		(u_long) xquad_portio, (u_long) num_quads*XQUAD_PORTIO_QUAD);
	}		}

	struct apic apic_numaq = {		/* Use __refdata to keep false positive warning calm. */
			struct apic __refdata apic_numaq = {

	.name = "NUMAQ",		.name = "NUMAQ",
	.probe = probe_numaq,		.probe = probe_numaq,