Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 746ae30f authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

isdn: make sure strings are null terminated 



These strings come from the user.  We strcpy() them inside
cf_command() so we should check that they are NULL terminated and
return an error if not.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1281bc25

drivers/isdn/divert/divert_procfs.c

+6 −0
Original line number Diff line number Diff line
@@ -242,6 +242,12 @@ static int isdn_divert_ioctl_unlocked(struct file *file, uint cmd, ulong arg) 
		case IIOCDOCFINT:

			if (!divert_if.drv_to_name(dioctl.cf_ctrl.drvid))

				return (-EINVAL);	/* invalid driver */

			if (strnlen(dioctl.cf_ctrl.msn, sizeof(dioctl.cf_ctrl.msn)) ==

					sizeof(dioctl.cf_ctrl.msn))

				return -EINVAL;

			if (strnlen(dioctl.cf_ctrl.fwd_nr, sizeof(dioctl.cf_ctrl.fwd_nr)) ==

					sizeof(dioctl.cf_ctrl.fwd_nr))

				return -EINVAL;

			if ((i = cf_command(dioctl.cf_ctrl.drvid,

					    (cmd == IIOCDOCFACT) ? 1 : (cmd == IIOCDOCFDIS) ? 0 : 2,

					    dioctl.cf_ctrl.cfproc,