Commit 74556f51 authored Jun 24, 2016 by Grygorii Strashko Committed by David S. Miller Jun 28, 2016

drivers: net: cpsw: remove pm runtime calls from suspend callbacks

PM runtime is properly handled in cpsw_ndo_open/stop(), as result it
isn't required to duplicate these calls in .suspend()/.resume()
callbacks. Moreover, it might cause unnecessary RPM resume of CPSW
during System suspend in the case it's already suspended because
all ethX interfaces are down already, before System suspend started.

Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 108a6537

drivers/net/ethernet/ti/cpsw.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -2563,8 +2563,6 @@ static int cpsw_suspend(struct device *dev)
		cpsw_ndo_stop(ndev);
		}

		pm_runtime_put_sync(&pdev->dev);

		/* Select sleep pin state */
		pinctrl_pm_select_sleep_state(&pdev->dev);

		@@ -2577,8 +2575,6 @@ static int cpsw_resume(struct device *dev)
		struct net_device *ndev = platform_get_drvdata(pdev);
		struct cpsw_priv *priv = netdev_priv(ndev);

		pm_runtime_get_sync(&pdev->dev);

		/* Select default pin state */
		pinctrl_pm_select_default_state(&pdev->dev);