Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 743fcc28 authored by Andrew Lunn's avatar Andrew Lunn Committed by David S. Miller
Browse files

net: dsa: mv88e6xxx: Print offending port when vlan check fails 



When testing if a VLAN is one more than one bridge, we print an error
message that the VLAN is already in use somewhere else. Print both the
new port which would like the VLAN, and the port which already has it,
to aid debugging.

Signed-off-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarVivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cd886469

drivers/net/dsa/mv88e6xxx/chip.c

+2 −2
Original line number Diff line number Diff line
@@ -1151,8 +1151,8 @@ static int mv88e6xxx_port_check_hw_vlan(struct dsa_switch *ds, int port, 
			if (!dsa_to_port(ds, i)->bridge_dev)

				continue;



			dev_err(ds->dev, "p%d: hw VLAN %d already used by %s\n",

				port, vlan.vid,

			dev_err(ds->dev, "p%d: hw VLAN %d already used by port %d in %s\n",

				port, vlan.vid, i,

				netdev_name(dsa_to_port(ds, i)->bridge_dev));

			err = -EOPNOTSUPP;

			goto unlock;