Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 74194fb9 authored by Maor Gottlieb's avatar Maor Gottlieb Committed by Doug Ledford
Browse files

net/mlx4_en: Implement mcast loopback prevention for ETH qps 



Set the mcast loopback prevention bit in the QPC for ETH MLX QPs (not
RSS QPs), when the firmware supports this feature. In addition, all rx
ring QPs need to be updated in order not to enforce loopback checks.
This prevents getting packets we sent both from the network stack and
the HCA. Loopback prevention is done by comparing the counter indices of
the sent and receiving QPs. If they're equal, packets aren't
loopback-ed.

Signed-off-by: default avatarMaor Gottlieb <maorg@mellanox.com>
Signed-off-by: default avatarEran Ben Elisha <eranbe@mellanox.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 9a892835

drivers/net/ethernet/mellanox/mlx4/en_main.c

+22 −0
Original line number Diff line number Diff line
@@ -123,6 +123,28 @@ void mlx4_en_update_loopback_state(struct net_device *dev, 
	 */

	if (mlx4_is_mfunc(priv->mdev->dev) || priv->validate_loopback)

		priv->flags |= MLX4_EN_FLAG_ENABLE_HW_LOOPBACK;



	mutex_lock(&priv->mdev->state_lock);

	if (priv->mdev->dev->caps.flags2 &

	    MLX4_DEV_CAP_FLAG2_UPDATE_QP_SRC_CHECK_LB &&

	    priv->rss_map.indir_qp.qpn) {

		int i;

		int err = 0;

		int loopback = !!(features & NETIF_F_LOOPBACK);



		for (i = 0; i < priv->rx_ring_num; i++) {

			int ret;



			ret = mlx4_en_change_mcast_lb(priv,

						      &priv->rss_map.qps[i],

						      loopback);

			if (!err)

				err = ret;

		}

		if (err)

			mlx4_warn(priv->mdev, "failed to change mcast loopback\n");

	}

	mutex_unlock(&priv->mdev->state_lock);

}



static int mlx4_en_get_profile(struct mlx4_en_dev *mdev)

drivers/net/ethernet/mellanox/mlx4/en_resources.c

+25 −0
Original line number Diff line number Diff line
@@ -69,6 +69,15 @@ void mlx4_en_fill_qp_context(struct mlx4_en_priv *priv, int size, int stride, 
	context->pri_path.counter_index = priv->counter_index;

	context->cqn_send = cpu_to_be32(cqn);

	context->cqn_recv = cpu_to_be32(cqn);

	if (!rss &&

	    (mdev->dev->caps.flags2 & MLX4_DEV_CAP_FLAG2_LB_SRC_CHK) &&

	    context->pri_path.counter_index !=

			    MLX4_SINK_COUNTER_INDEX(mdev->dev)) {

		/* disable multicast loopback to qp with same counter */

		if (!(dev->features & NETIF_F_LOOPBACK))

			context->pri_path.fl |= MLX4_FL_ETH_SRC_CHECK_MC_LB;

		context->pri_path.control |= MLX4_CTRL_ETH_SRC_CHECK_IF_COUNTER;

	}

	context->db_rec_addr = cpu_to_be64(priv->res.db.dma << 2);

	if (!(dev->features & NETIF_F_HW_VLAN_CTAG_RX))

		context->param3 |= cpu_to_be32(1 << 30);
@@ -80,6 +89,22 @@ void mlx4_en_fill_qp_context(struct mlx4_en_priv *priv, int size, int stride, 
	}

}



int mlx4_en_change_mcast_lb(struct mlx4_en_priv *priv, struct mlx4_qp *qp,

			    int loopback)

{

	int ret;

	struct mlx4_update_qp_params qp_params;



	memset(&qp_params, 0, sizeof(qp_params));

	if (!loopback)

		qp_params.flags = MLX4_UPDATE_QP_PARAMS_FLAGS_ETH_CHECK_MC_LB;



	ret = mlx4_update_qp(priv->mdev->dev, qp->qpn,

			     MLX4_UPDATE_QP_ETH_SRC_CHECK_MC_LB,

			     &qp_params);



	return ret;

}



int mlx4_en_map_buffer(struct mlx4_buf *buf)

{

drivers/net/ethernet/mellanox/mlx4/mlx4_en.h

+2 −1
Original line number Diff line number Diff line
@@ -798,7 +798,8 @@ void mlx4_en_fill_qp_context(struct mlx4_en_priv *priv, int size, int stride, 
void mlx4_en_sqp_event(struct mlx4_qp *qp, enum mlx4_event event);

int mlx4_en_map_buffer(struct mlx4_buf *buf);

void mlx4_en_unmap_buffer(struct mlx4_buf *buf);



int mlx4_en_change_mcast_lb(struct mlx4_en_priv *priv, struct mlx4_qp *qp,

			    int loopback);

void mlx4_en_calc_rx_buf(struct net_device *dev);

int mlx4_en_config_rss_steer(struct mlx4_en_priv *priv);

void mlx4_en_release_rss_steer(struct mlx4_en_priv *priv);