Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 73f2bdb9 authored by Corey Minyard's avatar Corey Minyard Committed by Linus Torvalds
Browse files

IPMI: convert message handler defines to an enum 



Convert the #defines for statistics into an enum in the IPMI message
handler.

Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent b2655f26

drivers/char/ipmi/ipmi_msghandler.c

+67 −58
Original line number Diff line number Diff line
@@ -189,90 +189,99 @@ struct bmc_device 
 * Various statistics for IPMI, these index stats[] in the ipmi_smi

 * structure.

 */

enum ipmi_stat_indexes {

	/* Commands we got from the user that were invalid. */

#define IPMI_STAT_sent_invalid_commands			0

	IPMI_STAT_sent_invalid_commands = 0,



	/* Commands we sent to the MC. */

#define IPMI_STAT_sent_local_commands			1

	IPMI_STAT_sent_local_commands,



	/* Responses from the MC that were delivered to a user. */

#define IPMI_STAT_handled_local_responses		2

	IPMI_STAT_handled_local_responses,



	/* Responses from the MC that were not delivered to a user. */

#define IPMI_STAT_unhandled_local_responses		3

	IPMI_STAT_unhandled_local_responses,



	/* Commands we sent out to the IPMB bus. */

#define IPMI_STAT_sent_ipmb_commands			4

	IPMI_STAT_sent_ipmb_commands,



	/* Commands sent on the IPMB that had errors on the SEND CMD */

#define IPMI_STAT_sent_ipmb_command_errs		5

	IPMI_STAT_sent_ipmb_command_errs,



	/* Each retransmit increments this count. */

#define IPMI_STAT_retransmitted_ipmb_commands		6

	IPMI_STAT_retransmitted_ipmb_commands,



/* When a message times out (runs out of retransmits) this is incremented. */

#define IPMI_STAT_timed_out_ipmb_commands		7

	/*

	 * When a message times out (runs out of retransmits) this is

	 * incremented.

	 */

	IPMI_STAT_timed_out_ipmb_commands,



	/*

	 * This is like above, but for broadcasts.  Broadcasts are

	 * *not* included in the above count (they are expected to

	 * time out).

	 */

#define IPMI_STAT_timed_out_ipmb_broadcasts		8

	IPMI_STAT_timed_out_ipmb_broadcasts,



	/* Responses I have sent to the IPMB bus. */

#define IPMI_STAT_sent_ipmb_responses			9

	IPMI_STAT_sent_ipmb_responses,



	/* The response was delivered to the user. */

#define IPMI_STAT_handled_ipmb_responses		10

	IPMI_STAT_handled_ipmb_responses,



	/* The response had invalid data in it. */

#define IPMI_STAT_invalid_ipmb_responses		11

	IPMI_STAT_invalid_ipmb_responses,



	/* The response didn't have anyone waiting for it. */

#define IPMI_STAT_unhandled_ipmb_responses		12

	IPMI_STAT_unhandled_ipmb_responses,



	/* Commands we sent out to the IPMB bus. */

#define IPMI_STAT_sent_lan_commands			13

	IPMI_STAT_sent_lan_commands,



	/* Commands sent on the IPMB that had errors on the SEND CMD */

#define IPMI_STAT_sent_lan_command_errs			14

	IPMI_STAT_sent_lan_command_errs,



	/* Each retransmit increments this count. */

#define IPMI_STAT_retransmitted_lan_commands		15

	IPMI_STAT_retransmitted_lan_commands,



/* When a message times out (runs out of retransmits) this is incremented. */

#define IPMI_STAT_timed_out_lan_commands		16

	/*

	 * When a message times out (runs out of retransmits) this is

	 * incremented.

	 */

	IPMI_STAT_timed_out_lan_commands,



	/* Responses I have sent to the IPMB bus. */

#define IPMI_STAT_sent_lan_responses			17

	IPMI_STAT_sent_lan_responses,



	/* The response was delivered to the user. */

#define IPMI_STAT_handled_lan_responses			18

	IPMI_STAT_handled_lan_responses,



	/* The response had invalid data in it. */

#define IPMI_STAT_invalid_lan_responses			19

	IPMI_STAT_invalid_lan_responses,



	/* The response didn't have anyone waiting for it. */

#define IPMI_STAT_unhandled_lan_responses		20

	IPMI_STAT_unhandled_lan_responses,



	/* The command was delivered to the user. */

#define IPMI_STAT_handled_commands			21

	IPMI_STAT_handled_commands,



	/* The command had invalid data in it. */

#define IPMI_STAT_invalid_commands			22

	IPMI_STAT_invalid_commands,



	/* The command didn't have anyone waiting for it. */

#define IPMI_STAT_unhandled_commands			23

	IPMI_STAT_unhandled_commands,



	/* Invalid data in an event. */

#define IPMI_STAT_invalid_events			24

	IPMI_STAT_invalid_events,



	/* Events that were received with the proper format. */

#define IPMI_STAT_events				25

	IPMI_STAT_events,





/* When you add a statistic, you must update this value. */

#define IPMI_NUM_STATS					26

	/* This *must* remain last, add new values above this. */

	IPMI_NUM_STATS

};





#define IPMI_IPMB_NUM_SEQ	64