Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 73e3f1eb authored by Kiran Padwal's avatar Kiran Padwal Committed by Mark Brown
Browse files

spi: pl022: Add missing error check for devm_kzalloc 



Currently this driver is missing a check on the return value of devm_kzalloc,
which would cause a NULL pointer dereference in a OOM situation.

This patch adds a missing check.

Signed-off-by: default avatarKiran Padwal <kiran.padwal@smartplayin.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 7d1311b9

drivers/spi/spi-pl022.c

+5 −0
Original line number Diff line number Diff line
@@ -2100,6 +2100,10 @@ static int pl022_probe(struct amba_device *adev, const struct amba_id *id) 
	pl022->vendor = id->data;

	pl022->chipselects = devm_kzalloc(dev, num_cs * sizeof(int),

					  GFP_KERNEL);

	if (!pl022->chipselects) {

		status = -ENOMEM;

		goto err_no_mem;

	}



	/*

	 * Bus Number Which has been Assigned to this SSP controller
@@ -2241,6 +2245,7 @@ static int pl022_probe(struct amba_device *adev, const struct amba_id *id) 
	amba_release_regions(adev);

 err_no_ioregion:

 err_no_gpio:

 err_no_mem:

	spi_master_put(master);

	return status;

}