Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 73b29514 authored by Kefeng Wang's avatar Kefeng Wang Committed by Tejun Heo
Browse files

ata: pata_of_platform: using of_property_read_u32() helper 



Using better of_property_read_u32() than generic of_get_property().

Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: default avatarKefeng Wang <wangkefeng.wang@huawei.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 5946fdae

drivers/ata/pata_of_platform.c

+2 −7
Original line number Diff line number Diff line
@@ -32,7 +32,6 @@ static int pata_of_platform_probe(struct platform_device *ofdev) 
	unsigned int reg_shift = 0;

	int pio_mode = 0;

	int pio_mask;

	const u32 *prop;



	ret = of_address_to_resource(dn, 0, &io_res);

	if (ret) {
@@ -50,13 +49,9 @@ static int pata_of_platform_probe(struct platform_device *ofdev) 


	irq_res = platform_get_resource(ofdev, IORESOURCE_IRQ, 0);



	prop = of_get_property(dn, "reg-shift", NULL);

	if (prop)

		reg_shift = be32_to_cpup(prop);

	of_property_read_u32(dn, "reg-shift", &reg_shift);



	prop = of_get_property(dn, "pio-mode", NULL);

	if (prop) {

		pio_mode = be32_to_cpup(prop);

	if (!of_property_read_u32(dn, "pio-mode", &pio_mode)) {

		if (pio_mode > 6) {

			dev_err(&ofdev->dev, "invalid pio-mode\n");

			return -EINVAL;