Commit 73615c86 authored Jan 29, 2014 by Ira W. Snyder Committed by Marc Kleine-Budde Jan 29, 2014

can: janz-ican3: fix uninitialized variable warnings



Analysis of the code shows that the struct ican3_msg variable cannot be
used uninitialized. Error conditions are checked and the loop terminates
before calling the ican3_handle_message() function with an uninitialized
value.

Signed-off-by: Ira W. Snyder <iws@ovro.caltech.edu>
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

parent bb5ecb0c

drivers/net/can/janz-ican3.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1322,7 +1322,7 @@ static int ican3_napi(struct napi_struct *napi, int budget)

		/* process all communication messages */
		while (true) {
		struct ican3_msg msg;
		struct ican3_msg uninitialized_var(msg);
		ret = ican3_recv_msg(mod, &msg);
		if (ret)
		break;