Commit 72dd831e authored Jan 07, 2018 by Gal Pressman Committed by David S. Miller Jan 08, 2018

net: Fix netdev_WARN_ONCE macro



netdev_WARN_ONCE is broken (whoops..), this fix will remove the
unnecessary "condition" parameter, add the missing comma and change
"arg" to "args".

Fixes: 375ef2b1 ("net: Introduce netdev_*_once functions")
Signed-off-by: Gal Pressman <galp@mellanox.com>
Reviewed-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9f0e896f

include/linux/netdevice.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -4409,8 +4409,8 @@ do { \
		WARN(1, "netdevice: %s%s\n" format, netdev_name(dev), \
		netdev_reg_state(dev), ##args)

		#define netdev_WARN_ONCE(dev, condition, format, arg...) \
		WARN_ONCE(1, "netdevice: %s%s\n" format, netdev_name(dev) \
		#define netdev_WARN_ONCE(dev, format, args...) \
		WARN_ONCE(1, "netdevice: %s%s\n" format, netdev_name(dev), \
		netdev_reg_state(dev), ##args)

		/* netif printk helpers, similar to netdev_printk */