Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 72da1f20 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab
Browse files

[media] uvcvideo: remove unneeded access_ok() check 



copy_in_user() already checks for write permission, so we don't need to
do it here.  This was added in 1a5e4c86 "[media] uvcvideo: Implement
compat_ioctl32 for custom ioctls".

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 004ac388

drivers/media/video/uvc/uvc_v4l2.c

+0 −2
Original line number Diff line number Diff line
@@ -1105,8 +1105,6 @@ static int uvc_v4l2_put_xu_mapping(const struct uvc_xu_control_mapping *kp, 
	if (get_user(p, &up->menu_info))

		return -EFAULT;

	umenus = compat_ptr(p);

	if (!access_ok(VERIFY_WRITE, umenus, kp->menu_count * sizeof(*umenus)))

		return -EFAULT;



	if (copy_in_user(umenus, kmenus, kp->menu_count * sizeof(*umenus)))

		return -EFAULT;