Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 727ecc5f authored by Gerrit Renker's avatar Gerrit Renker Committed by David S. Miller
Browse files

[DCCP]: Add FIXME for send_delayed_ack 



This adds a FIXME to signal that the function dccp_send_delayed_ack is nowhere
used in the entire DCCP/CCID code.

Using a delayed Ack timer is suggested in 11.3 of RFC 4340, but it has also
rather subtle implications for the Ack-Ratio-accounting.

CCID2 does not use this (maybe it should).

I think leaving the function in is good, in case someone wants to implement
this.

Signed-off-by: default avatarGerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@ghostprotocols.net>
parent 2e86908f

net/dccp/dccp.h

+0 −1
Original line number Diff line number Diff line
@@ -209,7 +209,6 @@ extern void dccp_v4_send_check(struct sock *sk, int len, struct sk_buff *skb); 
extern int  dccp_retransmit_skb(struct sock *sk, struct sk_buff *skb);



extern void dccp_send_ack(struct sock *sk);

extern void dccp_send_delayed_ack(struct sock *sk);

extern void dccp_reqsk_send_ack(struct sk_buff *sk, struct request_sock *rsk);



extern void dccp_send_sync(struct sock *sk, const u64 seq,

net/dccp/output.c

+1 −0
Original line number Diff line number Diff line
@@ -477,6 +477,7 @@ void dccp_send_ack(struct sock *sk) 


EXPORT_SYMBOL_GPL(dccp_send_ack);



/* FIXME: Is this still necessary (11.3) - currently nowhere used by DCCP. */

void dccp_send_delayed_ack(struct sock *sk)

{

	struct inet_connection_sock *icsk = inet_csk(sk);