Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 72219cea authored by Michael Wang's avatar Michael Wang Committed by Doug Ledford
Browse files

IB/Verbs: Use management helper rdma_cap_ib_cm() 



Introduce helper rdma_cap_ib_cm() to help us check if the port of an
IB device support Infiniband Communication Manager.

Signed-off-by: default avatarMichael Wang <yun.wang@profitbricks.com>
Reviewed-by: default avatarIra Weiny <ira.weiny@intel.com>
Tested-by: default avatarIra Weiny <ira.weiny@intel.com>
Reviewed-by: default avatarSean Hefty <sean.hefty@intel.com>
Reviewed-by: default avatarJason Gunthorpe <jgunthorpe@obsidianresearch.com>
Tested-by: default avatarDoug Ledford <dledford@redhat.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 29541e3a

drivers/infiniband/core/cm.c

+3 −3
Original line number Diff line number Diff line
@@ -3780,7 +3780,7 @@ static void cm_add_one(struct ib_device *ib_device) 


	set_bit(IB_MGMT_METHOD_SEND, reg_req.method_mask);

	for (i = 1; i <= ib_device->phys_port_cnt; i++) {

		if (!rdma_ib_or_iboe(ib_device, i))

		if (!rdma_cap_ib_cm(ib_device, i))

			continue;



		port = kzalloc(sizeof *port, GFP_KERNEL);
@@ -3831,7 +3831,7 @@ static void cm_add_one(struct ib_device *ib_device) 
	port_modify.set_port_cap_mask = 0;

	port_modify.clr_port_cap_mask = IB_PORT_CM_SUP;

	while (--i) {

		if (!rdma_ib_or_iboe(ib_device, i))

		if (!rdma_cap_ib_cm(ib_device, i))

			continue;



		port = cm_dev->port[i-1];
@@ -3863,7 +3863,7 @@ static void cm_remove_one(struct ib_device *ib_device) 
	write_unlock_irqrestore(&cm.device_lock, flags);



	for (i = 1; i <= ib_device->phys_port_cnt; i++) {

		if (!rdma_ib_or_iboe(ib_device, i))

		if (!rdma_cap_ib_cm(ib_device, i))

			continue;



		port = cm_dev->port[i-1];

drivers/infiniband/core/cma.c

+9 −10
Original line number Diff line number Diff line
@@ -745,7 +745,7 @@ int rdma_init_qp_attr(struct rdma_cm_id *id, struct ib_qp_attr *qp_attr, 
	int ret = 0;



	id_priv = container_of(id, struct rdma_id_private, id);

	if (rdma_ib_or_iboe(id->device, id->port_num)) {

	if (rdma_cap_ib_cm(id->device, id->port_num)) {

		if (!id_priv->cm_id.ib || (id_priv->id.qp_type == IB_QPT_UD))

			ret = cma_ib_init_qp_attr(id_priv, qp_attr, qp_attr_mask);

		else
@@ -1040,7 +1040,7 @@ void rdma_destroy_id(struct rdma_cm_id *id) 
	mutex_unlock(&id_priv->handler_mutex);



	if (id_priv->cma_dev) {

		if (rdma_ib_or_iboe(id_priv->id.device, 1)) {

		if (rdma_cap_ib_cm(id_priv->id.device, 1)) {

			if (id_priv->cm_id.ib)

				ib_destroy_cm_id(id_priv->cm_id.ib);

		} else if (rdma_protocol_iwarp(id_priv->id.device, 1)) {
@@ -1623,8 +1623,7 @@ static void cma_listen_on_dev(struct rdma_id_private *id_priv, 
	struct rdma_cm_id *id;

	int ret;



	if (cma_family(id_priv) == AF_IB &&

	    !rdma_ib_or_iboe(cma_dev->device, 1))

	if (cma_family(id_priv) == AF_IB && !rdma_cap_ib_cm(cma_dev->device, 1))

		return;



	id = rdma_create_id(cma_listen_handler, id_priv, id_priv->id.ps,
@@ -2015,7 +2014,7 @@ static int cma_bind_loopback(struct rdma_id_private *id_priv) 
	mutex_lock(&lock);

	list_for_each_entry(cur_dev, &dev_list, list) {

		if (cma_family(id_priv) == AF_IB &&

		    !rdma_ib_or_iboe(cur_dev->device, 1))

		    !rdma_cap_ib_cm(cur_dev->device, 1))

			continue;



		if (!cma_dev)
@@ -2524,7 +2523,7 @@ int rdma_listen(struct rdma_cm_id *id, int backlog) 


	id_priv->backlog = backlog;

	if (id->device) {

		if (rdma_ib_or_iboe(id->device, 1)) {

		if (rdma_cap_ib_cm(id->device, 1)) {

			ret = cma_ib_listen(id_priv);

			if (ret)

				goto err;
@@ -2868,7 +2867,7 @@ int rdma_connect(struct rdma_cm_id *id, struct rdma_conn_param *conn_param) 
		id_priv->srq = conn_param->srq;

	}



	if (rdma_ib_or_iboe(id->device, id->port_num)) {

	if (rdma_cap_ib_cm(id->device, id->port_num)) {

		if (id->qp_type == IB_QPT_UD)

			ret = cma_resolve_ib_udp(id_priv, conn_param);

		else
@@ -2979,7 +2978,7 @@ int rdma_accept(struct rdma_cm_id *id, struct rdma_conn_param *conn_param) 
		id_priv->srq = conn_param->srq;

	}



	if (rdma_ib_or_iboe(id->device, id->port_num)) {

	if (rdma_cap_ib_cm(id->device, id->port_num)) {

		if (id->qp_type == IB_QPT_UD) {

			if (conn_param)

				ret = cma_send_sidr_rep(id_priv, IB_SIDR_SUCCESS,
@@ -3042,7 +3041,7 @@ int rdma_reject(struct rdma_cm_id *id, const void *private_data, 
	if (!id_priv->cm_id.ib)

		return -EINVAL;



	if (rdma_ib_or_iboe(id->device, id->port_num)) {

	if (rdma_cap_ib_cm(id->device, id->port_num)) {

		if (id->qp_type == IB_QPT_UD)

			ret = cma_send_sidr_rep(id_priv, IB_SIDR_REJECT, 0,

						private_data, private_data_len);
@@ -3069,7 +3068,7 @@ int rdma_disconnect(struct rdma_cm_id *id) 
	if (!id_priv->cm_id.ib)

		return -EINVAL;



	if (rdma_ib_or_iboe(id->device, id->port_num)) {

	if (rdma_cap_ib_cm(id->device, id->port_num)) {

		ret = cma_modify_qp_err(id_priv);

		if (ret)

			goto out;

drivers/infiniband/core/ucm.c

+1 −1
Original line number Diff line number Diff line
@@ -1253,7 +1253,7 @@ static void ib_ucm_add_one(struct ib_device *device) 
	dev_t base;

	struct ib_ucm_device *ucm_dev;



	if (!device->alloc_ucontext || !rdma_ib_or_iboe(device, 1))

	if (!device->alloc_ucontext || !rdma_cap_ib_cm(device, 1))

		return;



	ucm_dev = kzalloc(sizeof *ucm_dev, GFP_KERNEL);

include/rdma/ib_verbs.h

+15 −0
Original line number Diff line number Diff line
@@ -1804,6 +1804,21 @@ static inline bool rdma_cap_ib_smi(struct ib_device *device, u8 port_num) 
	return rdma_protocol_ib(device, port_num);

}



/**

 * rdma_cap_ib_cm - Check if the port of device has the capability Infiniband

 * Communication Manager.

 *

 * @device: Device to be checked

 * @port_num: Port number of the device

 *

 * Return false when port of the device don't support Infiniband

 * Communication Manager.

 */

static inline bool rdma_cap_ib_cm(struct ib_device *device, u8 port_num)

{

	return rdma_ib_or_iboe(device, port_num);

}



int ib_query_gid(struct ib_device *device,

		 u8 port_num, int index, union ib_gid *gid);