Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 721e3eba authored by Theodore Ts'o's avatar Theodore Ts'o
Browse files

ext4: lock i_mutex when truncating orphan inodes



Commit c278531d added a warning when ext4_flush_unwritten_io() is
called without i_mutex being taken.  It had previously not been taken
during orphan cleanup since races weren't possible at that point in
the mount process, but as a result of this c278531d, we will now see
a kernel WARN_ON in this case.  Take the i_mutex in
ext4_orphan_cleanup() to suppress this warning.

Reported-by: default avatarAlexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: default avatarZheng Liu <wenqing.lz@taobao.com>
Cc: stable@vger.kernel.org
parent d096ad0f
Loading
Loading
Loading
Loading
+2 −0
Original line number Diff line number Diff line
@@ -2220,7 +2220,9 @@ static void ext4_orphan_cleanup(struct super_block *sb,
				__func__, inode->i_ino, inode->i_size);
			jbd_debug(2, "truncating inode %lu to %lld bytes\n",
				  inode->i_ino, inode->i_size);
			mutex_lock(&inode->i_mutex);
			ext4_truncate(inode);
			mutex_unlock(&inode->i_mutex);
			nr_truncates++;
		} else {
			ext4_msg(sb, KERN_DEBUG,