Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 71c68c4f authored by Dave Jones's avatar Dave Jones Committed by Russell King
Browse files

drm/i2c: tda998x: Fix memory leak in tda998x_encoder_init error path. 



Commit 6ae668cc (drm/i2c: tda998x: check the CEC device creation)
introduced a memory leak in the error path of tda998x_encoder_init

Picked up by the nightly Coverity scan. CID 1174076

Signed-off-by: default avatarDave Jones <davej@fedoraproject.org>
Acked-by: default avatarJean-Francois Moine <moinejf@free.fr>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent 2e9a3fc3

drivers/gpu/drm/i2c/tda998x_drv.c

+3 −1
Original line number Diff line number Diff line
@@ -1151,8 +1151,10 @@ tda998x_encoder_init(struct i2c_client *client, 


	priv->current_page = 0xff;

	priv->cec = i2c_new_dummy(client->adapter, 0x34);

	if (!priv->cec)

	if (!priv->cec) {

		kfree(priv);

		return -ENODEV;

	}

	priv->dpms = DRM_MODE_DPMS_OFF;



	encoder_slave->slave_priv = priv;