Commit 71a9fda3 authored Nov 07, 2017 by Colin Ian King Committed by Felipe Balbi Dec 11, 2017

usb: gadget: pxa27x: Remove redundant assignment to is_short and dev



Variable is_short is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.  Pointer dev is assigned a value that
is not read and it is updated a few statements later, this too is
redundant and can be removed. Cleans up clan warnings:

drivers/usb/gadget/udc/pxa27x_udc.c:986:3: warning: Value stored
to 'is_short' is never read
drivers/usb/gadget/udc/pxa27x_udc.c:1141:2: warning: Value stored
to 'dev' is never read

Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

parent 1fd4c45d

drivers/usb/gadget/udc/pxa27x_udc.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -979,8 +979,6 @@ static int write_fifo(struct pxa_ep ep, struct pxa27x_request req)

		max = ep->fifo_size;
		do {
		is_short = 0;

		udccsr = udc_ep_readl(ep, UDCCSR);
		if (udccsr & UDCCSR_PC) {
		ep_vdbg(ep, "Clearing Transmit Complete, udccsr=%x\n",
		@@ -1134,7 +1132,6 @@ static int pxa_ep_queue(struct usb_ep _ep, struct usb_request _req,
		if (unlikely(!_ep))
		return -EINVAL;

		dev = udc_usb_ep->dev;
		ep = udc_usb_ep->pxa_ep;
		if (unlikely(!ep))
		return -EINVAL;