Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 713d4024 authored by Guenter Roeck's avatar Guenter Roeck Committed by David S. Miller
Browse files

net: bfin_mac: Use phy_find_first() instead of open-coding it 



Use phy_find_first() to find the first phy device instead of
open-coding it.

Cc: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 50ee6382

drivers/net/ethernet/adi/bfin_mac.c

+2 −15
Original line number Diff line number Diff line
@@ -380,9 +380,8 @@ static void bfin_mac_adjust_link(struct net_device *dev) 
static int mii_probe(struct net_device *dev, int phy_mode)

{

	struct bfin_mac_local *lp = netdev_priv(dev);

	struct phy_device *phydev = NULL;

	struct phy_device *phydev;

	unsigned short sysctl;

	int i;

	u32 sclk, mdc_div;



	/* Enable PHY output early */
@@ -396,19 +395,7 @@ static int mii_probe(struct net_device *dev, int phy_mode) 
	sysctl = (sysctl & ~MDCDIV) | SET_MDCDIV(mdc_div);

	bfin_write_EMAC_SYSCTL(sysctl);



	/* search for connected PHY device */

	for (i = 0; i < PHY_MAX_ADDR; ++i) {

		struct phy_device *const tmp_phydev =

			mdiobus_get_phy(lp->mii_bus, i);



		if (!tmp_phydev)

			continue; /* no PHY here... */



		phydev = tmp_phydev;

		break; /* found it */

	}



	/* now we are supposed to have a proper phydev, to attach to... */

	phydev = phy_find_first(lp->mii_bus);

	if (!phydev) {

		netdev_err(dev, "no phy device found\n");

		return -ENODEV;