Commit 7075654c authored Jun 19, 2019 by Rasmus Villemoes Committed by Greg Kroah-Hartman Jul 14, 2019

net: dsa: mv88e6xxx: fix shift of FID bits in mv88e6185_g1_vtu_loadpurge()



[ Upstream commit 48620e341659f6e4b978ec229f6944dabe6df709 ]

The comment is correct, but the code ends up moving the bits four
places too far, into the VTUOp field.

Fixes: 11ea809f (net: dsa: mv88e6xxx: support 256 databases)
Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 606561e1

drivers/net/dsa/mv88e6xxx/global1_vtu.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -419,7 +419,7 @@ int mv88e6185_g1_vtu_loadpurge(struct mv88e6xxx_chip *chip,
		* VTU DBNum[7:4] are located in VTU Operation 11:8
		*/
		op \|= entry->fid & 0x000f;
		op \|= (entry->fid & 0x00f0) << 8;
		op \|= (entry->fid & 0x00f0) << 4;
		}

		return mv88e6xxx_g1_vtu_op(chip, op);