Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6fd98c12 authored by Subramaniam Chanderashekarapuram's avatar Subramaniam Chanderashekarapuram Committed by Ohad Ben-Cohen
Browse files

remoteproc: fix off-by-one bug in __rproc_free_vrings 



Fix a nasty off-by-one bug in __rproc_free_vrings which
resulted in a memory leak and (for some platforms) failures
to reload the remote processor.

Signed-off-by: default avatarSubramaniam Chanderashekarapuram <subramaniam.ca@ti.com>
[ohad@wizery.com: reword commit log, stick with the for loop]
Signed-off-by: default avatarOhad Ben-Cohen <ohad@wizery.com>
parent d48b97b4

drivers/remoteproc/remoteproc_core.c

+1 −1
Original line number Diff line number Diff line
@@ -354,7 +354,7 @@ static void __rproc_free_vrings(struct rproc_vdev *rvdev, int i) 
{

	struct rproc *rproc = rvdev->rproc;



	for (i--; i > 0; i--) {

	for (i--; i >= 0; i--) {

		struct rproc_vring *rvring = &rvdev->vring[i];

		int size = PAGE_ALIGN(vring_size(rvring->len, rvring->align));