Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6f9fdeb6 authored by Ralf Baechle's avatar Ralf Baechle
Browse files

MIPS: Module: Make error messages unique. 



There were three different errors resulting in a "dangerous relocation"
message.  Add the relocation type to the messgages to make them more
useful.

Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent 39b3d446

arch/mips/kernel/module.c

+5 −3
Original line number Diff line number Diff line
@@ -98,7 +98,8 @@ static int apply_r_mips_32_rela(struct module *me, u32 *location, Elf_Addr v) 
static int apply_r_mips_26_rel(struct module *me, u32 *location, Elf_Addr v)

{

	if (v % 4) {

		printk(KERN_ERR "module %s: dangerous relocation\n", me->name);

		pr_err("module %s: dangerous R_MIPS_26 REL relocation\n",

		       me->name);

		return -ENOEXEC;

	}
@@ -118,7 +119,8 @@ static int apply_r_mips_26_rel(struct module *me, u32 *location, Elf_Addr v) 
static int apply_r_mips_26_rela(struct module *me, u32 *location, Elf_Addr v)

{

	if (v % 4) {

		printk(KERN_ERR "module %s: dangerous relocation\n", me->name);

		pr_err("module %s: dangerous R_MIPS_26 RELArelocation\n",

		       me->name);

		return -ENOEXEC;

	}
@@ -222,7 +224,7 @@ static int apply_r_mips_lo16_rel(struct module *me, u32 *location, Elf_Addr v) 
	return 0;



out_danger:

	printk(KERN_ERR "module %s: dangerous " "relocation\n", me->name);

	pr_err("module %s: dangerous R_MIPS_LO16 REL relocation\n", me->name);



	return -ENOEXEC;

}