Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6f38cf25 authored by Namhyung Kim's avatar Namhyung Kim Committed by Arnaldo Carvalho de Melo
Browse files

perf sort: Clean up sort__first_dimension setting 



It doesn't need to compare to every sort key names since the index
already has the required information.

Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1356599507-14226-9-git-send-email-namhyung@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent cb993744

tools/perf/util/sort.c

+2 −24
Original line number Diff line number Diff line
@@ -526,30 +526,8 @@ int sort_dimension__add(const char *tok) 
		if (sd->entry->se_collapse)

			sort__need_collapse = 1;



		if (list_empty(&hist_entry__sort_list)) {

			if (!strcmp(sd->name, "pid"))

				sort__first_dimension = SORT_PID;

			else if (!strcmp(sd->name, "comm"))

				sort__first_dimension = SORT_COMM;

			else if (!strcmp(sd->name, "dso"))

				sort__first_dimension = SORT_DSO;

			else if (!strcmp(sd->name, "symbol"))

				sort__first_dimension = SORT_SYM;

			else if (!strcmp(sd->name, "parent"))

				sort__first_dimension = SORT_PARENT;

			else if (!strcmp(sd->name, "cpu"))

				sort__first_dimension = SORT_CPU;

			else if (!strcmp(sd->name, "symbol_from"))

				sort__first_dimension = SORT_SYM_FROM;

			else if (!strcmp(sd->name, "symbol_to"))

				sort__first_dimension = SORT_SYM_TO;

			else if (!strcmp(sd->name, "dso_from"))

				sort__first_dimension = SORT_DSO_FROM;

			else if (!strcmp(sd->name, "dso_to"))

				sort__first_dimension = SORT_DSO_TO;

			else if (!strcmp(sd->name, "mispredict"))

				sort__first_dimension = SORT_MISPREDICT;

		}

		if (list_empty(&hist_entry__sort_list))

			sort__first_dimension = i;



		list_add_tail(&sd->entry->list, &hist_entry__sort_list);

		sd->taken = 1;