Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6f061487 authored by Jay Fenlason's avatar Jay Fenlason Committed by Stefan Richter
Browse files

firewire: fw-sbp2: correctly dereference by container_of 



Replace a cast with a container_of().  As long as nobody reorders the
structure elements, they do the same thing, but container_of() is more
readable.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> (added complete_command_orb)
Acked-by: default avatarKristian Høgsberg <krh@redhat.com>
parent 7ada60e3

drivers/firewire/fw-sbp2.c

+3 −2
Original line number Diff line number Diff line
@@ -395,7 +395,7 @@ static void 
complete_management_orb(struct sbp2_orb *base_orb, struct sbp2_status *status)

{

	struct sbp2_management_orb *orb =

	    (struct sbp2_management_orb *)base_orb;

		container_of(base_orb, struct sbp2_management_orb, base);



	if (status)

		memcpy(&orb->status, status, sizeof(*status));
@@ -838,7 +838,8 @@ sbp2_status_to_sense_data(u8 *sbp2_status, u8 *sense_data) 
static void

complete_command_orb(struct sbp2_orb *base_orb, struct sbp2_status *status)

{

	struct sbp2_command_orb *orb = (struct sbp2_command_orb *)base_orb;

	struct sbp2_command_orb *orb =

		container_of(base_orb, struct sbp2_command_orb, base);

	struct fw_unit *unit = orb->unit;

	struct fw_device *device = fw_device(unit->device.parent);

	struct scatterlist *sg;